Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

[Richard Kuo]

On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote:
> As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is
> used to add arch-specific options for $(CC). From commandline,
> CFLAGS_MODULE shall be used.
> Doesn't have any functional change, but just follow kbuild rules.
> 
> Signed-off-by: Cao jin <caoj.fnst@xxxxxxxxxxxxxx>
> CC: Richard Kuo <rkuo@xxxxxxxxxxxxxx>
> CC: linux-hexagon@xxxxxxxxxxxxxxx
> ---
>  arch/hexagon/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/hexagon/Makefile b/arch/hexagon/Makefile
> index 207711a0..4f5c84c 100644
> --- a/arch/hexagon/Makefile
> +++ b/arch/hexagon/Makefile
> @@ -11,9 +11,9 @@ KBUILD_CFLAGS += -fno-short-enums
>  
>  # Modules must use either long-calls, or use pic/plt.
>  # Use long-calls for now, it's easier.  And faster.
> -# CFLAGS_MODULE += -fPIC
> -# LDFLAGS_MODULE += -shared
> -CFLAGS_MODULE += -mlong-calls
> +# KBUILD_CFLAGS_MODULE += -fPIC
> +# KBUILD_LDFLAGS_MODULE += -shared
> +KBUILD_CFLAGS_MODULE += -mlong-calls
>  
>  cflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
>  aflags-y += $(call cc-option,-mv${CONFIG_HEXAGON_ARCH_VERSION})
> -- 
> 2.1.0
> 
> 
> 

For Hexagon:

Acked-by: Richard Kuo <rkuo@xxxxxxxxxxxxxx>

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, 
a Linux Foundation Collaborative Project