Re: [PATCH v2 0/3] pinctrl: sunxi: Start to enforce the strict mode

[Chen-Yu Tsai]

On Tue, Oct 10, 2017 at 4:53 AM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> Hi,
>
> Here is an attempt to enable pinctrl's strict mode on our pinctrl drivers.
> Indeed, our controllers should have had that mode enabled since its
> introduction.
>
> However, there's a number of issues with old device trees that prevent from
> just enabling it for all the devices. There's basically two of them:
>
>   - Most of our old DTs have a pinctrl node for GPIOs, which will result in
>     an error when the driver is going to request the gpio because it would
>     already be requested automatically by pinctrl. We cannot break those.
>
>   - Some of these GPIOs also need to change their pin configuration to add
>     a bias or change the current output, and there isn't a migration path.
>
> Let's just keep the old behaviour for the old SoCs, and enforce it on the
> new one, and enabled it by default so that the situation at least doesn't
> get worse.
>
> This has been tested on an A83t (strict on) and an H3 (strict off) board.
>
> Let me know what you think,
> Maxime
>
> Changes from v1:
>   - Duplicate the pmx_ops before modifying them
>   - Disable the strict mode for R_PIO as well
>
> Maxime Ripard (3):
>   pinctrl: sunxi: Introduce the strict flag
>   pinctrl: sunxi: Disable strict mode for old pinctrl drivers
>   pinctrl: sunxi: Enforce the strict mode by default

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>