Re: [PATCH 3/3] drm: Add CRTC_GET_SEQUENCE and CRTC_QUEUE_SEQUENCE ioctls [v2]

[Daniel Vetter]

On Mon, Oct 09, 2017 at 10:18:30AM -0700, Keith Packard wrote:
> Daniel Vetter <daniel@xxxxxxxx> writes:
> 
> > I just figured that -modesetting would be the simplest domenstration
> > vehicle, since the vulkan patches don't look ready yet. I need fully
> > reviewed&tested userspace before we can land any kernel stuff. Doing
> > the quick modesetting conversion would unblock.
> 
> I've provided a patch for the modesetting driver and the preliminary
> bits are merged, leaving only a fairly straightforward addition of the
> new ioctls to that code. I'm not sure how to make more progress there at
> this point; that code would need testing, and it requires a hand-patched
> kernel to test.
> 
> I also posted IGT tests for the new functionality, again, getting those
> reviewed and tested depends on someone willing to build a patched
> kernel. Dave Airlie has started trying to get that done.
> 
> >> (regarding FIRST_PIXEL_OUT):
> >>
> >> If the timestamp is the only important thing, it sounds like the kernel
> >> already satisfies that, which is cool.
> >
> > Would be good to confirm that. If it's not, we have a problem.
> 
> Michel Dänzer says that the timestamp provided is computed to be
> first_pixel_out for all hardware. Given that, I suggest we specify that
> in the documentation and remove this bit from the API.
> 
> Seem reasonable?

Ack on all. It looks like Dave is taking care of merging too, in that
case ack on all these patches from my side.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch