Re: [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node of pmic.

[m18063]

Hi Wenyou,

On 10.10.2017 03:39, Yang, Wenyou wrote:
> Hi Claudiu,
> 
> 
> On 2017/10/10 0:09, Claudiu Beznea wrote:
>> Add charger device node as a sub-device node of act8945a mfd, move
>> the charger's properties to this node, and use the "interrupts"
>> property to replace "active-semi,irq_gpios" to denote the act8945a
>> charger's irq.
>>
>> Signed-off-by: Wenyou Yang <wenyou.yang@xxxxxxxxx>
>> [claudiu.beznea@xxxxxxxxxxxxx: replace numbers with pin macros]
>> Signed-off-by: Claudiu Beznea <claudiu.beznea@xxxxxxxxxxxxx>
> This patch has already applied on at91-dt branch.
> https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=at91-dt&id=4b6ad41f267b8ddabf5dd1b02a318bc74f0b95e9
> 
Thanks, I will remove it from v2.

>> ---
>> Â arch/arm/boot/dts/at91-sama5d2_xplained.dts | 23 +++++++++++++++--------
>> Â 1 file changed, 15 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> index c7e9ccf2bc87..848ca1b025be 100644
>> --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
>> @@ -160,14 +160,6 @@
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ compatible = "active-semi,act8945a";
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ reg = <0x5b>;
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,vsel-high;
>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,irq_gpios = <&pioA PIN_PB13 GPIO_ACTIVE_LOW>;
>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,input-voltage-threshold-microvolt = <6600>;
>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,precondition-timeout = <40>;
>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,total-timeout = <3>;
>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinctrl-names = "default";
>> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ status = "okay";
>> Â ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ regulators {
>> @@ -220,6 +212,21 @@
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ regulator-always-on;
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ charger {
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ compatible = "active-semi,act8945a-charger";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinctrl-names = "default";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ interrupt-parent = <&pioA>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ interrupts = <PIN_PB13 GPIO_ACTIVE_LOW>;
>> +
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,input-voltage-threshold-microvolt = <6600>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,precondition-timeout = <40>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ active-semi,total-timeout = <3>;
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ status = "okay";
>> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> ÂÂÂÂÂÂÂÂÂÂÂÂÂ };
>> Â 
> 
> Best Regards,
> Wenyou Yang