Re: [PATCH v2] acpi/arm64: pr_err() strings should end with newlines

From: Lorenzo Pieralisi
Date: Tue Oct 10 2017 - 06:24:50 EST


On Tue, Oct 10, 2017 at 05:33:50PM +0800, Hanjun Guo wrote:
> On 2017/9/25 15:24, Arvind Yadav wrote:
> > pr_err() messages should terminated with a new-line to avoid
> > other messages being concatenated onto the end.
> >
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> > ---
> > changes in v2:
> > Add changelog.
> >
> > drivers/acpi/arm64/gtdt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> > index 597a737..92f9edf 100644
> > --- a/drivers/acpi/arm64/gtdt.c
> > +++ b/drivers/acpi/arm64/gtdt.c
> > @@ -199,7 +199,7 @@ static int __init gtdt_parse_timer_block(struct acpi_gtdt_timer_block *block,
> > struct acpi_gtdt_timer_entry *gtdt_frame;
> >
> > if (!block->timer_count) {
> > - pr_err(FW_BUG "GT block present, but frame count is zero.");
> > + pr_err(FW_BUG "GT block present, but frame count is zero.\n");
> > return -ENODEV;
> > }
> >
>
> Make sense to me,
>
> Acked-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
>
> Lorenzo, could you pick this up for 4.15?

Sure, thanks for reminding.

Thanks,
Lorenzo