Re: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

[Greg KH]

On Mon, Oct 09, 2017 at 05:51:52PM -0500, Mario Limonciello wrote:
> +	ret = device_create_file(&wdev->dev, &priv->req_buf_size_attr);
> +	if (ret)
> +		goto fail_create_sysfs;

Why isn't the "WMI core" creating this sysfs file?  Why have per-driver
sysfs files, making all of the different apis totally different?  It's a
"common" attribute that they are all going to have to provide, right?

That way you also don't race with userspace :)

thanks,

greg k-h