Re: [PATCH V2] writeback: merge try_to_writeback_inodes_sb_nr() into caller

From: Jens Axboe
Date: Tue Oct 10 2017 - 10:15:09 EST


On 10/10/2017 03:43 AM, Rakesh Pandit wrote:
> Hi Jens,
>
> On Mon, Oct 09, 2017 at 02:00:29PM +0200, Jan Kara wrote:
>> On Mon 09-10-17 13:34:41, Rakesh Pandit wrote:
>>> Since commit 925a6efb8ff0c ("Btrfs: stop using
>>> try_to_writeback_inodes_sb_nr to flush delalloc") this function hasn't
>>> been used outside so stop exporting it.
>>>
>>> In addition we merge it into try_to_writeback_inodes_sb() which is the
>>> only caller. Also change return type of try_to_writeback_inodes_sb to
>>> void as the only user ext4 doesn't care.
>>>
>>> Signed-off-by: Rakesh Pandit <rakesh@xxxxxxxxxx>
>>
>> Looks good. You can add:
>>
>> Reviewed-by: Jan Kara <jack@xxxxxxx>
>>
>> Honza
>
> As there are many writeback related changes on your tree would you be
> okay queuing this up as well for-4.15 with above reviewed-by tag ?
>
> This should apply fine on your tree for-4.15.
>
> Let me know if that isn't okay.

That's fine, I'll queue it up.

--
Jens Axboe