Re: [PATCH 6/6] drm: Add four ioctls for managing drm mode object leases [v4]

[Keith Packard]

Dave Airlie <airlied@xxxxxxxxx> writes:

>> +                */
>> +               ret = idr_alloc(&leases, &drm_lease_idr_object , object_id, object_id + 1, GFP_KERNEL);
>
> In current kernels, the idr_alloc warns if start < 0, so if object_id
> is a negative signed integer, which your
> igt tests actually make it.
>
> So we get an ugly debug splat from the idr code, you should probably
> make sure object_id is
> something valid in signed space first, to avoid the splat.

Yeah, makes sense. I also found the vboxvideo driver in staging which
needed an API tweak.

I've pushed that as drm-lease-v5 and will plan on dumping that to the
list when you're done with -v4.

There are a couple of conflicts and another update needed when merging
leases and the new vblank ioctls together; once we've got one of the two
ready to go, I can rebase the other on top of that and fix things up.

-- 
-keith

Attachment: signature.asc
Description: PGP signature