Re: [PATCH 2/4] perf/ftrace: Fix function trace events

From: Jiri Olsa
Date: Wed Oct 11 2017 - 10:23:16 EST


On Wed, Oct 11, 2017 at 09:04:20AM -0400, Steven Rostedt wrote:
> On Wed, 11 Oct 2017 13:59:54 +0200
> Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
>
> > > @@ -330,7 +354,7 @@ perf_ftrace_function_call(unsigned long
> > > entry->ip = ip;
> > > entry->parent_ip = parent_ip;
> > > perf_trace_buf_submit(entry, ENTRY_SIZE, rctx, TRACE_FN,
> > > - 1, &regs, head, NULL);
> > > + 1, &regs, &head, NULL);
> >
> > nice idea.. I'll test it
>
> After you test it, want me to take this through my tree?

peter's call ;-)

> Also, we should address zhouchengming's concerns.

agreed.. I tested and it looks ok to me

jirka