Re: [PATCH 00/35] perf annotate: Use generic annotation line

[Arnaldo Carvalho de Melo]

Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu:
> hi,
> I'm working on script profiling support and came up

Can you describe what you mean by "script profiling" and "script
annotation"?

- Arnaldo

> with some generic annotation code changes, which IMO
> make the code simpler and more generic.
> 
> The main idea of this patchset is to have generic
> struct (annotation_line), which holds the common
> profile data. Having this we can easily add new
> types, like script annotation support. Currently
> there's disasm_line support only.
> 
> It's also available at:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git perf/annotate
> 
> I'm getting same annotation results for this patchset as
> in the current perf, but I might have missed something.
> 
> thanks,
> jirka
> 
> ---
>  tools/perf/arch/arm/annotate/instructions.c     |   3 +-
>  tools/perf/arch/arm64/annotate/instructions.c   |   3 +-
>  tools/perf/arch/powerpc/annotate/instructions.c |   4 +-
>  tools/perf/arch/s390/annotate/instructions.c    |   4 +-
>  tools/perf/arch/x86/annotate/instructions.c     |  14 +++
>  tools/perf/builtin-top.c                        |   2 +-
>  tools/perf/ui/browsers/annotate.c               | 404 +++++++++++++++++++++++++++++++++++-------------------------------------
>  tools/perf/ui/gtk/annotate.c                    |  23 ++---
>  tools/perf/util/annotate.c                      | 635 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------------------
>  tools/perf/util/annotate.h                      |  76 ++++++++------
>  10 files changed, 609 insertions(+), 559 deletions(-)