Re: [PATCH 2/2] drm: vblank: remove drm_timestamp_monotonic parameter

[Daniel Stone]

On 11 October 2017 at 16:20, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> There is a risk of overflowing vblank timestamps in 2038 or 2106 if
> someone sets the drm_timestamp_monotonic module parameter to zero.
>
> I found no indication of anyone ever setting the parameter, or
> complaining about the default being wrong, after it was introduced
> as a way to handle backwards-compatibility with linux prior to
> c61eef726a78 ("drm: add support for monotonic vblank timestamps"),
> so it's probably safer to just remove the parameter completely
> and only allowing the default behavior.

I don't think there's any reason to remain suspicious of
CLOCK_MONOTONIC in 2017. Not to mention that removing it wrecks
Weston/etc's ability to give clients present-timing feedback, so
removing it is a net uABI improvement.

Acked-by: Daniel Stone <daniels@xxxxxxxxxxxxx>

Cheers,
Daniel