Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

From: Gustavo A. R. Silva
Date: Wed Oct 11 2017 - 11:59:52 EST


Hi Johan,

Quoting Johan Hovold <johan@xxxxxxxxxx>:

On Tue, Oct 10, 2017 at 03:10:41PM -0500, Gustavo A. R. Silva wrote:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>

Acked-by: Johan Hovold <johan@xxxxxxxxxx>

Patch is fine, but next time make sure to run scripts/get_maintainer.sh
to figure which people and lists to CC.


I actually did:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback drivers/staging/greybus/es2.c

and this was the output:

linux-kernel@xxxxxxxxxxxxxxx (open list)

We also try to include the module (component) "es2" in the commit
summary (unless you really are doing things subsystem wide), although
that has not been enforced for staging clean ups recently.


I got it. I'll take that into account for future patches.

Thanks
--
Gustavo A. R. Silva