Re: [PATCH] staging: greybus: mark expected switch fall-through in check_urb_status

[Gustavo A. R. Silva]

Quoting Johan Hovold <johan@xxxxxxxxxx>:

> On Wed, Oct 11, 2017 at 10:12:50AM -0500, Gustavo A. R. Silva wrote:
> > Hi Johan,
> >
> > Quoting Johan Hovold <johan@xxxxxxxxxx>:
>
> > > Patch is fine, but next time make sure to run scripts/get_maintainer.sh
> > > to figure which people and lists to CC.
> > >
> >
> > I actually did:
> >
> > $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback
> > drivers/staging/greybus/es2.c
> >
> > and this was the output:
> >
> > linux-kernel@xxxxxxxxxxxxxxx (open list)
>
> Very odd. If I run the exact same command I get the expected result:
>
> Johan Hovold <johan@xxxxxxxxxx> (maintainer:GREYBUS SUBSYSTEM)
> Alex Elder <elder@xxxxxxxxxx> (maintainer:GREYBUS SUBSYSTEM)
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> (maintainer:GREYBUS  
> SUBSYSTEM)
> greybus-dev@xxxxxxxxxxxxxxxx (moderated list:GREYBUS SUBSYSTEM)
> devel@xxxxxxxxxxxxxxxxxxxx (open list:STAGING SUBSYSTEM)
> linux-kernel@xxxxxxxxxxxxxxx (open list)

I double checked and this is what happened:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers//staging/greybus/es2.c

Notice that double slash after drivers: //

For some reason I was running that command instead of this one:

$ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback  
drivers/staging/greybus/es2.c

> > > We also try to include the module (component) "es2" in the commit
> > > summary (unless you really are doing things subsystem wide), although
> > > that has not been enforced for staging clean ups recently.
> > >
> >
> > I got it. I'll take that into account for future patches.
>
> Looking at the commit history for the file in questions usually gives a
> hint about the style used for the corresponding subsystem.

Yep, I usually do that:

$ git log --oneline drivers/staging/greybus/es2.c

This time I got many of these two:

staging: greybus:
greybus: es2:

so I picked up the first one.

But I get your point and I understand now that I should have used the  
second one.

Thanks
--
Gustavo A. R. Silva