Re: [PATCH 00/35] perf annotate: Use generic annotation line

[Arnaldo Carvalho de Melo]

Em Wed, Oct 11, 2017 at 09:30:05PM +0200, Jiri Olsa escreveu:
> On Wed, Oct 11, 2017 at 04:18:59PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Oct 11, 2017 at 09:10:57PM +0200, Jiri Olsa escreveu:
> > > On Wed, Oct 11, 2017 at 12:27:09PM -0300, Arnaldo Carvalho de Melo wrote:
> > > > Em Wed, Oct 11, 2017 at 05:01:23PM +0200, Jiri Olsa escreveu:
> > > > > I'm working on script profiling support and came up

> > > > Can you describe what you mean by "script profiling" and "script
> > > > annotation"?

> > > I have some prototype code that allows to get the
> > > internal script stack to the sample and display

> > What is an "internal script stack"? Ah, looking further below you mean
> > "python scripts", I see!
 
> yep, the stack/callchain inside script ;-) only python so far
 
> > Please try to state what you want to achieve in a detailed way as you go
> > writing the patches, that eases reviewing, not requiring us to go
> > looking at _all_ the patches in a series to then figure out and restart
> > reviewing patch by patch...
> 
> well I think the annotation patches i sent can stand on their own
> and also I did not want to send it all in 50+ patches bomb

Yeah, but understanding what you want to get to helps in reviewing,
anyway, now I know :-)

- Arnaldo