Re: [PATCH v6 1/2] pid: Replace pid bitmap implementation with IDR API

From: Rik van Riel
Date: Wed Oct 11 2017 - 18:28:33 EST


On Wed, 2017-10-11 at 18:19 -0400, Gargi Sharma wrote:
> This patch replaces the current bitmap implemetation for
> Process ID allocation. Functions that are no longer required,
> for example, free_pidmap(), alloc_pidmap(), etc. are removed.
> The rest of the functions are modified to use the IDR API.
> The change was made to make the PID allocation less complex by
> replacing custom code with calls to generic API.
>
> Signed-off-by: Gargi Sharma <gs051095@xxxxxxxxx>
> ---
> Âarch/powerpc/platforms/cell/spufs/sched.c |ÂÂÂ2 +-
> Âfs/proc/loadavg.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ2 +-
> Âinclude/linux/pid_namespace.hÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ14 +--
> Âinit/main.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ2 +-
> Âkernel/pid.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 201 ++++++------------
> ------------
> Âkernel/pid_namespace.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ44 +++----
> Â6 files changed, 57 insertions(+), 208 deletions(-)

I'm all out of nitpicks now :)
Also, I really love that diffstat.

Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>

--
All Rights Reversed.

Attachment: signature.asc
Description: This is a digitally signed message part