Re: [PATCH v6 11/14] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver

From: kbuild test robot
Date: Wed Oct 11 2017 - 21:03:16 EST


Hi Mario,

[auto build test ERROR on platform-drivers-x86/for-next]
[also build test ERROR on v4.14-rc4 next-20171009]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Mario-Limonciello/Introduce-support-for-Dell-SMBIOS-over-WMI/20171012-082742
base: git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git for-next
config: x86_64-randconfig-x018-201741 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All error/warnings (new ones prefixed by >>):

In file included from include/linux/kobject.h:21:0,
from include/linux/module.h:17,
from drivers/platform/x86/dell-smbios.c:18:
drivers/platform/x86/dell-smbios.c: In function 'build_tokens_sysfs':
>> include/linux/sysfs.h:54:8: error: 'struct device_attribute' has no member named 'key'
(attr)->key = &__key; \
^
>> drivers/platform/x86/dell-smbios.c:443:3: note: in expansion of macro 'sysfs_attr_init'
sysfs_attr_init(&token_location_attrs[i]);
^~~~~~~~~~~~~~~
>> include/linux/sysfs.h:54:8: error: 'struct device_attribute' has no member named 'key'
(attr)->key = &__key; \
^
drivers/platform/x86/dell-smbios.c:455:3: note: in expansion of macro 'sysfs_attr_init'
sysfs_attr_init(&token_value_attrs[i]);
^~~~~~~~~~~~~~~
--
In file included from include/linux/kobject.h:21:0,
from include/linux/module.h:17,
from drivers/platform//x86/dell-smbios.c:18:
drivers/platform//x86/dell-smbios.c: In function 'build_tokens_sysfs':
>> include/linux/sysfs.h:54:8: error: 'struct device_attribute' has no member named 'key'
(attr)->key = &__key; \
^
drivers/platform//x86/dell-smbios.c:443:3: note: in expansion of macro 'sysfs_attr_init'
sysfs_attr_init(&token_location_attrs[i]);
^~~~~~~~~~~~~~~
>> include/linux/sysfs.h:54:8: error: 'struct device_attribute' has no member named 'key'
(attr)->key = &__key; \
^
drivers/platform//x86/dell-smbios.c:455:3: note: in expansion of macro 'sysfs_attr_init'
sysfs_attr_init(&token_value_attrs[i]);
^~~~~~~~~~~~~~~

vim +54 include/linux/sysfs.h

^1da177e Linus Torvalds 2005-04-16 38
35960258 Eric W. Biederman 2010-02-12 39 /**
35960258 Eric W. Biederman 2010-02-12 40 * sysfs_attr_init - initialize a dynamically allocated sysfs attribute
35960258 Eric W. Biederman 2010-02-12 41 * @attr: struct attribute to initialize
35960258 Eric W. Biederman 2010-02-12 42 *
35960258 Eric W. Biederman 2010-02-12 43 * Initialize a dynamically allocated struct attribute so we can
35960258 Eric W. Biederman 2010-02-12 44 * make lockdep happy. This is a new requirement for attributes
35960258 Eric W. Biederman 2010-02-12 45 * and initially this is only needed when lockdep is enabled.
35960258 Eric W. Biederman 2010-02-12 46 * Lockdep gives a nice error when your attribute is added to
35960258 Eric W. Biederman 2010-02-12 47 * sysfs if you don't have this.
35960258 Eric W. Biederman 2010-02-12 48 */
6992f533 Eric W. Biederman 2010-02-11 49 #ifdef CONFIG_DEBUG_LOCK_ALLOC
6992f533 Eric W. Biederman 2010-02-11 50 #define sysfs_attr_init(attr) \
6992f533 Eric W. Biederman 2010-02-11 51 do { \
6992f533 Eric W. Biederman 2010-02-11 52 static struct lock_class_key __key; \
6992f533 Eric W. Biederman 2010-02-11 53 \
6992f533 Eric W. Biederman 2010-02-11 @54 (attr)->key = &__key; \
6992f533 Eric W. Biederman 2010-02-11 55 } while (0)
6992f533 Eric W. Biederman 2010-02-11 56 #else
6992f533 Eric W. Biederman 2010-02-11 57 #define sysfs_attr_init(attr) do {} while (0)
6992f533 Eric W. Biederman 2010-02-11 58 #endif
6992f533 Eric W. Biederman 2010-02-11 59

:::::: The code at line 54 was first introduced by commit
:::::: 6992f5334995af474c2b58d010d08bc597f0f2fe sysfs: Use one lockdep class per sysfs attribute.

:::::: TO: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: application/gzip