Re: [PATCH] m68k: pull mach_beep in setup.c

[Geert Uytterhoeven]

Hi Greg,

On Thu, Oct 12, 2017 at 2:15 AM, Greg Ungerer <gerg@xxxxxxxxxxxxxx> wrote:
> On 28/09/17 19:44, Alexandre Belloni wrote:
>> It is possible to select INPUT_M68K_BEEP in a nommu configuration. This
>> results in the following link error:
>>
>> drivers/input/misc/m68kspkr.o: In function `m68kspkr_event':
>> m68kspkr.c:(.text+0x3a): undefined reference to `mach_beep'
>> m68kspkr.c:(.text+0x5e): undefined reference to `mach_beep'
>> m68kspkr.c:(.text+0x78): undefined reference to `mach_beep'
>> drivers/input/misc/m68kspkr.o: In function `m68kspkr_init':
>> m68kspkr.c:(.init.text+0x4): undefined reference to `mach_beep'
>>
>> Pull the mach_beep definition in setup.c to avoid it.
>>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
>
> I plan on applying this to the m68knommu git tree (for-next) branch
> in the very near future.
>
> Geert: no objections?

No objections:
Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds