Re: [PATCH] PM / QoS: Drop PM_QOS_FLAG_REMOTE_WAKEUP

[Ulf Hansson]

On 13 October 2017 at 02:35, Rafael J. Wysocki <rjw@xxxxxxxxxxxxx> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> The PM QoS flag PM_QOS_FLAG_REMOTE_WAKEUP is not used consistently
> and the vast majority of code simply assumes that remote wakeup
> should be enabled for devices in runtime suspend if they can
> generate wakeup signals, so drop it.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

With a minor nitpick below, please add:

Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

> ---
>  drivers/acpi/device_pm.c    |    6 ++----
>  drivers/base/power/domain.c |    4 +---
>  drivers/base/power/sysfs.c  |   28 ----------------------------
>  include/linux/pm_qos.h      |    1 -
>  4 files changed, 3 insertions(+), 36 deletions(-)

I found the flag to also be mentioned in the
Documentation/power/pm_qos_interface.txt, could please remove that
part as well.

[...]

Kind regards
Uffe