Re: [PATCHv3 1/1] mmc: core: export emmc revision

[Jisheng Zhang]

On Thu, 12 Oct 2017 10:46:59 -0700 Jin Qian wrote:

> From: Jin Qian <jinqian@xxxxxxxxxx>
> 
> Expose emmc revision as part of device attributes.
> 
> Signed-off-by: Jin Qian <jinqian@xxxxxxxxxxx>
> ---

A trivial point: when you send newer version, could you add change log
so that it's clearly expressed what's updated/addressed.

>  Documentation/ABI/testing/sysfs-bus-mmc | 4 ++++
>  drivers/mmc/core/mmc.c                  | 2 ++
>  2 files changed, 6 insertions(+)
>  create mode 100644 Documentation/ABI/testing/sysfs-bus-mmc
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-mmc b/Documentation/ABI/testing/sysfs-bus-mmc
> new file mode 100644
> index 000000000000..519f028d19cc
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-bus-mmc
> @@ -0,0 +1,4 @@
> +What:		/sys/bus/mmc/devices/.../rev
> +Date:		October 2017
> +Contact:	Jin Qian <jinqian@xxxxxxxxxxx>
> +Description:	Extended CSD revision number
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 36217ad5e9b1..4aa4cfb2c9e1 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -780,6 +780,7 @@ MMC_DEV_ATTR(manfid, "0x%06x\n", card->cid.manfid);
>  MMC_DEV_ATTR(name, "%s\n", card->cid.prod_name);
>  MMC_DEV_ATTR(oemid, "0x%04x\n", card->cid.oemid);
>  MMC_DEV_ATTR(prv, "0x%x\n", card->cid.prv);
> +MMC_DEV_ATTR(rev, "0x%x\n", card->ext_csd.rev);
>  MMC_DEV_ATTR(pre_eol_info, "%02x\n", card->ext_csd.pre_eol_info);
>  MMC_DEV_ATTR(life_time, "0x%02x 0x%02x\n",
>  	card->ext_csd.device_life_time_est_typ_a,
> @@ -838,6 +839,7 @@ static struct attribute *mmc_std_attrs[] = {
>  	&dev_attr_name.attr,
>  	&dev_attr_oemid.attr,
>  	&dev_attr_prv.attr,
> +	&dev_attr_rev.attr,
>  	&dev_attr_pre_eol_info.attr,
>  	&dev_attr_life_time.attr,
>  	&dev_attr_serial.attr,