Re: [PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset

From: Guilherme G. Piccoli
Date: Fri Oct 13 2017 - 09:04:01 EST


On 10/13/2017 05:37 AM, Michael Ellerman wrote:
>
> I really dislike this.
>
> You're basically saying the kernel can't work out how to get a device
> working, so let's leave it up to the user.

Oh, it was never my intention to say such blasphemy :)
It meant to be just a debug option to help the users, specifically the
ones debugging drivers, to try using a hammer to recover bad devices! To
this issue that I mentioned as an example, the fix specifically goes in
the FW of the adapter.

Anyway, since you really dislike it, let's drop it, no big deal!
Cheers,


Guilherme

>
> The driver should be fixed to detect that the device is not responding
> and request a reset.
>
> cheers
>