Re: [PATCH 4.4 23/31] drm/bridge: adv7511: Use work_struct to defer hotplug handing to out of irq context

[Ben Hutchings]

On Tue, 2017-09-12 at 09:56 -0700, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.ÂÂIf anyone has any objections, please let me
> know.
> 
> ------------------
> 
> From: John Stultz <john.stultz@xxxxxxxxxx>
> 
> commit 518cb7057a59b9441336d2e88a396d52b6ab0cce upstream.
> 
> I was recently seeing issues with EDID probing, where
> the logic to wait for the EDID read bit to be set by the
> IRQ wasn't happening and the code would time out and fail.
> 
> Digging deeper, I found this was due to the fact that
> IRQs were disabled as we were running in IRQ context from
> the HPD signal.
> 
> Thus this patch changes the logic to handle the HPD signal
> via a work_struct so we can be out of irq context.
[...]

Shouldn't there also be a cancel_work_sync() in the remove function?

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.