Re: [PATCH] kmemcheck: correctly remove kmemcheck call from dma_map_sg_attrs

[Levin, Alexander (Sasha Levin)]

On Fri, Oct 13, 2017 at 09:11:21AM +0200, Michal Hocko wrote:
>On Thu 12-10-17 19:22:05, Sasha Levin wrote:
>> We have missed removing some code as part of removing the kmemcheck
>> hooks.
>>
>> Unfourtenatly this got missed during my review, and the code was
>> still building.
>>
>> Reported-by: Michal Hocko <mhocko@xxxxxxxxxx>
>> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
>
>Yes this would be the proper fix for the specific issue I have noticed.
>There might be others I haven't even checked. Really the only way to
>make this chage is to post a reproducible steps to regenerate your diff
>and review that the used scripts are correct. Follow up fixes are not a
>way to go

So the only part of this series that was scripted to some extend was
this commit we're looking at. The 3 other commits are done manually
(although their large size is mostly attributed to 'git rm').

Even for this commit, I don't see a way to have it completely scripted
given that we're not simply removing calls.

I've looked at the ~50 deletions of kmemcheck calls in this commit to
make sure they make sense.

-- 

Thanks,
Sasha