Re: [PATCH] tracing, memcg, vmscan: Hide trace events when not in use

From: Steven Rostedt
Date: Fri Oct 13 2017 - 10:28:55 EST


On Fri, 13 Oct 2017 08:38:26 +0200
Michal Hocko <mhocko@xxxxxxxxxx> wrote:

> I do not understand the ftrace machinery

Not many do :-/

> and I have to admit I was under
> impression that nothing really gets defined if the code using them
> doesn't exist but if this is not the case then this patch makes sense to
> me

Sometimes events are created by kernel proper that are used by modules,
or created by modules to be used by other modules (kvm does this with
kvm_intel and kvm_amd). Unfortunately, for these cases they need to
stay. Or later, I plan on moving them to where they are used, because
they have the same issue (wasting memory).

>
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
>
> Acked-by: Michal Hocko <mhocko@xxxxxxxx>

Thanks!

-- Steve