Re: [PATCH] i2c: pxa: move header file out of deprecated i2c folder

From: Wolfram Sang
Date: Fri Oct 13 2017 - 17:45:14 EST


Hi Robert,

> I'm sorry I completely missed this one.

No worries, that happens.

> Either it's too late and trash this mail, or it's not, and then I'd suggest
> another approach :
> - patch 1 : move include/linux/i2c/pxa-i2c.h to include/platform_data/i2c-pxa.h
> (i2c-pxa.h and not pxa-i2c.h to be consistent)
> - patch 2 : move this chunk to arch/arm/mach-pxa/devices.h
> > extern void pxa_set_i2c_info(struct i2c_pxa_platform_data *info);
> >
> > #ifdef CONFIG_PXA27x
> > extern void pxa27x_set_i2c_power_info(struct i2c_pxa_platform_data *info);
> > #endif
> >
> > #ifdef CONFIG_PXA3xx
> > extern void pxa3xx_set_i2c_power_info(struct i2c_pxa_platform_data *info);
> > #endif
>
> This is the cleanest approach I could think of.

OK, will resend with your suggestions somewhen soon.

Thanks,

Wolfram

Attachment: signature.asc
Description: PGP signature