Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property

[Lothar WaÃmann]

Hi,

On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-KÃnig wrote:
> Hello,
> 
> On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar WaÃmann wrote:
> > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> > index 211e67d..3c852f7 100644
> > --- a/arch/arm/boot/dts/imx28-tx28.dts
> > +++ b/arch/arm/boot/dts/imx28-tx28.dts
> > @@ -328,8 +328,7 @@
> >  		reg = <0x20>;
> >  		pinctrl-names = "default";
> >  		pinctrl-0 = <&tx28_pca9554_pins>;
> > -		interrupt-parent = <&gpio3>;
> > -		interrupts = <28 0>;
> > +		interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>;
> >  		gpio-controller;
> >  		#gpio-cells = <2>;
> >  		interrupt-controller;
> 
> While interrupts-extended looks nice,
> Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> has:
> 
> 	"interrupts-extended" should only be used when a device has
> 	multiple interrupt parents.
> 
> If this is still true, this patch is wrong.
>
Thanks for the hint. It really helps to read the documentation
sometimes, rahter than relying on existing code only...

A quick check shows, that more than 100 of the 130 uses of
interrupts-extended are wrong. :(


Lothar WaÃmann