Re: [PATCH] platform/x86: mlx-platform: make a couple of structures static
From: Darren Hart
Date: Mon Oct 16 2017 - 17:26:33 EST
On Sat, Oct 07, 2017 at 05:03:41PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 5, 2017 at 1:42 PM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:
> > From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> > The structures mlxplat_dev and mlxplat_hotplug are local to the source
> > and do not need to be in global scope, so make them static.
> >
> > Cleans up sparse warnings:
> > symbol 'mlxplat_dev' was not declared. Should it be static?
> > symbol 'mlxplat_hotplug' was not declared. Should it be static?
>
> Thanks for the patch.
> Since Vadim did some rather big driver changes I would like to hear
> from him how to proceed with this one: either I apply it now, or after
> we get Vadim's series in.
>
I've asked Vadim to rework some of the mlx platform and hotplug patches, so I'll
be taking this now as it is a minimal patch - this way it doesn't get lost.
Thanks Colin.
--
Darren Hart
VMware Open Source Technology Center