Re: [PATCH 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute

[Chanwoo Choi]

Hi,

On 2017ë 10ì 16ì 16:34, Raveendra Padasalagi wrote:
> Add documentation on optional dt attribute "debounce-timeout-ms"
> in extcon node to capture user specified timeout value for id
> and vbus gpio detection.
> 
> Signed-off-by: Raveendra Padasalagi <raveendra.padasalagi@xxxxxxxxxxxx>
> Reviewed-by: Ray Jui <ray.jui@xxxxxxxxxxxx>
> Reviewed-by: Srinath Mannam <srinath.mannam@xxxxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> index dfc14f7..6df6d69 100644
> --- a/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> +++ b/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt
> @@ -10,6 +10,10 @@ Either one of id-gpio or vbus-gpio must be present. Both can be present as well.
>  - id-gpio: gpio for USB ID pin. See gpio binding.
>  - vbus-gpio: gpio for USB VBUS pin.
>  
> +Optional properties:
> +- debounce-timeout-ms: debounce timeout value for id and vbus gpio in
> +  milliseconds.

I recommend that you use the 'input-debounce' propery name
instead of 'debounce-timeout-ms'.

When I check the pinctrl-bindings.txt[1] in order to check
the property name for debounce. The documentation[1] specify
the generic pinconfig property name.
[1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt

> +
>  Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below:
>  	extcon_usb1 {
>  		compatible = "linux,extcon-usb-gpio";
> 
-- 
Best Regards,
Chanwoo Choi
Samsung Electronics