[PATCH v2 12/12] of: overlay: remove unneeded check for NULL kbasename()

From: frowand . list
Date: Mon Oct 16 2017 - 21:18:28 EST


From: Frank Rowand <frank.rowand@xxxxxxxx>

kbasename() will not return NULL if passed a valid string. If
the parameter passed to kbasename() in this case is already NULL
then the devicetree has been corrupted.

Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxx>
---
drivers/of/overlay.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index a257474c9223..dc7657329aea 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -322,8 +322,6 @@ static int add_changeset_node(struct overlay_changeset *ovcs,
int ret = 0;

node_kbasename = kbasename(node->full_name);
- if (!node_kbasename)
- return -ENOMEM;

for_each_child_of_node(target_node, tchild)
if (!of_node_cmp(node_kbasename, kbasename(tchild->full_name)))
--
Frank Rowand <frank.rowand@xxxxxxxx>