Re: [PATCH] scsi: nsp32: fix logic bug in error handling

From: Martin K. Petersen
Date: Mon Oct 16 2017 - 22:41:07 EST



Masanori,

>> gcc-8 points out a logic error that has existed since the start
>> of the git history:
>>
>> drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi':
>> drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to false [-Werror=tautological-compare]
>> if(((phase & BUSMON_BSY) == 1) || (phase & BUSMON_SEL) == 1) {

Applied to 4.15/scsi-queue. Thanks, Arnd!

--
Martin K. Petersen Oracle Linux Engineering