Re: [PATCH] staging/comedi: Convert timers to use timer_setup()

[Ian Abbott]

On 17/10/17 00:25, Kees Cook wrote:
> In preparation for unconditionally passing the struct timer_list pointer
> to all timer callbacks, switch to using the new timer_setup() and
> from_timer() to pass the timer pointer explicitly. Adds pointer back to
> comedi device from private struct.
>
> Cc: Ian Abbott <abbotti@xxxxxxxxx>
> Cc: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> ---
>   drivers/staging/comedi/drivers/comedi_test.c | 18 ++++++++++--------
>   drivers/staging/comedi/drivers/das16.c       | 11 ++++++-----
>   drivers/staging/comedi/drivers/jr3_pci.c     | 10 ++++++----
>   3 files changed, 22 insertions(+), 17 deletions(-)

It looks fine to me.

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-