Re: [PATCH 11/23] drm/sun4i: Rename layers to UI planes

[Chen-Yu Tsai]

On Tue, Oct 17, 2017 at 5:06 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> The currently supported planes for DE2 are actually only UI planes, and the
> VI planes will differ both in terms of code and features.
>
> It will make sense to support them in a separate file, so let's make sure
> we don't create a confusing file name.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/sun4i/Makefile      |   2 +-
>  drivers/gpu/drm/sun4i/sun8i_layer.c | 134 +-----------------------------
>  drivers/gpu/drm/sun4i/sun8i_layer.h |  36 +--------
>  drivers/gpu/drm/sun4i/sun8i_mixer.c |   4 +-
>  drivers/gpu/drm/sun4i/sun8i_ui.c    | 134 +++++++++++++++++++++++++++++-
>  drivers/gpu/drm/sun4i/sun8i_ui.h    |  36 ++++++++-
>  6 files changed, 173 insertions(+), 173 deletions(-)
>  delete mode 100644 drivers/gpu/drm/sun4i/sun8i_layer.c
>  delete mode 100644 drivers/gpu/drm/sun4i/sun8i_layer.h
>  create mode 100644 drivers/gpu/drm/sun4i/sun8i_ui.c
>  create mode 100644 drivers/gpu/drm/sun4i/sun8i_ui.h
>

[...]

> diff --git a/drivers/gpu/drm/sun4i/sun8i_ui.c b/drivers/gpu/drm/sun4i/sun8i_ui.c
> new file mode 100644
> index 000000000000..077099ef565a
> --- /dev/null
> +++ b/drivers/gpu/drm/sun4i/sun8i_ui.c
> @@ -0,0 +1,134 @@

[...]

> +static const struct sun8i_plane_desc sun8i_mixer_planes[] = {

You might want to update this name as well to be consistent.

Otherwise,

Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>