Re: [PATCH 21/23] arm: dts: sun8i: a711: Add regulator support

[Chen-Yu Tsai]

On Tue, Oct 17, 2017 at 5:06 PM, Maxime Ripard
<maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:

No description?

> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> ---
>  arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 163 +++++++++++++++++++++--
>  1 file changed, 154 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> index 723641f56a74..98dc0c22160b 100644
> --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
> +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts

[...]

> +&reg_dldo2 {
> +       regulator-min-microvolt = <2800000>;
> +       regulator-max-microvolt = <4200000>;
> +       regulator-name = "vcc-mipi";

Is this connected to anything? The wide voltage range
is kind of fishy.

[...]

> @@ -193,7 +338,7 @@
>  };
>
>  &usbphy {
> -       usb1_vbus_supply = <&reg_vcc5v0>;
> -       usb2_vbus_supply = <&reg_vcc5v0>;
> +       usb1_vbus_supply = <&reg_vmain>;
> +       usb2_vbus_supply = <&reg_vmain>;

I wonder why this wasn't done earlier.


Regards
ChenYu