Re: [PATCH v5 1/2] acpi: apei: remove the unused dead-code for SEA/NMI notification type

From: Tyler Baicar
Date: Tue Oct 17 2017 - 10:06:51 EST


On 10/17/2017 4:02 AM, Dongjiu Geng wrote:
For the SEA notification, the two functions ghes_sea_add() and
ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA
is defined. If not, it will return errors in the ghes_probe()
and not continue. If the probe is failed, the ghes_sea_remove()
also has no chance to be called. Hence, remove the unnecessary
handling when CONFIG_ACPI_APEI_SEA is not defined.

For the NMI notification, it has the same issue as SEA notification,
so also remove the unused dead-code for it.

Cc: Tyler Baicar <tbaicar@xxxxxxxxxxxxxx>
Cc: James Morse <james.morse@xxxxxxx>
Signed-off-by: Dongjiu Geng <gengdongjiu@xxxxxxxxxx>
Tested-by: Tyler Baicar <tbaicar@xxxxxxxxxxxxxx>

I've verified v5 of this series testing the SEA path.

Thanks,
Tyler