RE: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to compile as module

[Duyck, Alexander H]

> -----Original Message-----
> From: Eric Dumazet [mailto:edumazet@xxxxxxxxxx]
> Sent: Tuesday, October 17, 2017 4:21 AM
> To: Henrik Austad <henrik@xxxxxxxxx>
> Cc: netdev <netdev@xxxxxxxxxxxxxxx>; David S . Miller
> <davem@xxxxxxxxxxxxx>; Daniel Borkmann <daniel@xxxxxxxxxxxxx>; David
> Ahern <dsahern@xxxxxxxxx>; Duyck, Alexander H
> <alexander.h.duyck@xxxxxxxxx>; Willem de Bruijn <willemb@xxxxxxxxxx>;
> John Fastabend <john.fastabend@xxxxxxxxx>; tcharding <me@xxxxxxxx>; LKML
> <linux-kernel@xxxxxxxxxxxxxxx>; Henrik Austad <haustad@xxxxxxxxx>; Sanchez-
> Palencia, Jesus <jesus.sanchez-palencia@xxxxxxxxx>
> Subject: Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to
> compile as module
> 
> On Tue, Oct 17, 2017 at 3:10 AM, Henrik Austad <henrik@xxxxxxxxx> wrote:
> > In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW
> > traffic classes and misc IDs") sch_mqprio started using
> > netdev_txq_to_tc to find the correct tc instead of dev->tc_to_txq[]
> >
> > However, when mqprio is compiled as a module, it cannot resolve the
> > symbol, leading to this error:
> >
> >      ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined!
> >
> > This adds an EXPORT_SYMBOL() since the other user in the kernel
> > (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a
> > sysfs-callback.
> >
> > Cc: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>
> > Cc: Jesus Sanchez-Palencia <jesus.sanchez-palencia@xxxxxxxxx>
> > Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> > Signed-off-by: Henrik Austad <haustad@xxxxxxxxx>
> 
> 
> Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>

This is identical to a patch I submitted yesterday when I got the report from the kbuild robot. I would say your description looks much better than mine though so I would be good with dropping my patch in favor of this one.

Acked-by: Alexander Duyck <alexander.h.duyck@xxxxxxxxx>