Re: [PATCH 05/23] drm/sun4i: tcon: Don't rely on encoders to enable the TCON

[Maxime Ripard]

On Tue, Oct 17, 2017 at 05:28:42PM +0800, Chen-Yu Tsai wrote:
> On Tue, Oct 17, 2017 at 5:06 PM, Maxime Ripard
> <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote:
> > So far, we've required all the TCON-connected encoders to call the TCON
> > enable and disable functions.
> >
> > This was made this way because in the RGB/LVDS case, the TCON is the CRTC
> > and the encoder. However, in all the other cases (HDMI, TV, DSI, etc.), we
> > have another encoder down the road that needs to be programmed.
> >
> > We also needed to know which channel the encoder is connected to, which is
> > encoder-specific.
> >
> > The CRTC's enable and disable callbacks can work just fine for our use
> > case, and we can get the channel to use just by looking at the type of
> > encoder, since that is fixed. Implement those callbacks, which will
> > remove some of the encoder boilerplate.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> 
> Reviewed-by: Chen-Yu Tsai <wens@xxxxxxxx>

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature