Re: [PATCH] timers: avoid an unnecessory iteration in __run_timers()

[Anna-Maria Gleixner]

On Sun, 8 Oct 2017, Zhenzhong Duan wrote:

> When we know next expired timer is later than current jiffies, we don't need to
> call collect_expired_timers() again checking empty hlists.
> 
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@xxxxxxxxxx>

Acked-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>

Thanks,

	Anna-Maria

> ---
>  kernel/time/timer.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/time/timer.c b/kernel/time/timer.c
> index f2674a0..02be824 100644
> --- a/kernel/time/timer.c
> +++ b/kernel/time/timer.c
> @@ -1560,8 +1560,7 @@ static int collect_expired_timers(struct timer_base *base,
>  		 * jiffies, otherwise forward to the next expiry time:
>  		 */
>  		if (time_after(next, jiffies)) {
> -			/* The call site will increment clock! */
> -			base->clk = jiffies - 1;
> +			base->clk = jiffies;
>  			return 0;
>  		}
>  		base->clk = next;
> -- 
> 1.7.3
>