Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations

From: James Bottomley
Date: Tue Oct 17 2017 - 11:57:21 EST


On Tue, 2017-10-17 at 11:25 +0200, SF Markus Elfring wrote:
> >
> > Fixes is only for bug fixes.ÂÂThese don't fix any bugs.
>
> How do you distinguish these in questionable source code
> from other error categories or software weaknesses?

A style change is one that doesn't change the effect of the execution.
ÂThese don't actually even change the assembly, so there's programmatic
proof they're not fixing anything.

Bug means potentially user visible fault. ÂIn any bug fix commit you
should document the fault and its effects on users so those backporting
can decide if they care or not.

James