Re: [patch v4 2/3] platform/mellanox: mlxreg-hotplug: allow driver for ARM architecture

[Andy Shevchenko]

On Tue, Oct 17, 2017 at 9:22 PM, Vadim Pasternak <vadimp@xxxxxxxxxxxx> wrote:
> It allows driver to run on x86 and ARM architecture based systems.
> And allows to specify hotplug device parameters through the device
> table tree files.
> Also some unnecessary includes are removed.

>  menuconfig MELLANOX_PLATFORM
>         bool "Platform support for Mellanox hardware"
> -       depends on X86 || COMPILE_TEST
> +       depends on (X86 && !OF_DYNAMIC) || ARM || COMPILE_TEST

I'm not sure I now understand why you need a tricky dependency chain here...

> +#if defined(CONFIG_OF_DYNAMIC) && !defined(CONFIG_COMPILE_TEST)

...and what's wrong with COMPILE_TEST here.

> +static int mlxreg_hotplug_of_device_create(struct mlxreg_hotplug_device *data)
> +{
> +       return of_update_property(data->np, &mlxreg_hotplug_device_en);
> +}
> +
> +static void
> +mlxreg_hotplug_of_device_destroy(struct mlxreg_hotplug_device *data)
> +{
> +       of_update_property(data->np, &mlxreg_hotplug_device_dis);
> +       of_node_clear_flag(data->np, OF_POPULATED);
> +}
> +#else

> +#endif

-- 
With Best Regards,
Andy Shevchenko