Re: [PATCH v2] watchdog: core: Make use of devm_register_reboot_notifier()
From: Andrew Morton
Date: Tue Oct 17 2017 - 18:08:18 EST
On Tue, 17 Oct 2017 08:50:12 -0700 Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote:
> On Sat, Apr 15, 2017 at 11:11 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > On 04/11/2017 09:06 AM, Andrey Smirnov wrote:
> >>
> >> Save a bit of cleanup code by leveraging newly added
> >> devm_register_reboot_notifier().
> >>
> >> Cc: cphealy@xxxxxxxxx
> >> Cc: linux-kernel@xxxxxxxxxxxxxxx
> >> Cc: Wim Van Sebroeck <wim@xxxxxxxxx>
> >> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> >> Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> >> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>
> >
> >
> > Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> >
>
> Andrew,
>
> This patch can't go in via watchdog tree because it depends on
> devm_register_reboot_notifier() which is still present only in
> linux-next, any change you can pull this into linux-next as well?
That's because I've been sitting on
kernel-reboot-add-devm_register_reboot_notifier.patch since March
because it has no users.
This patch adds a user. Have you identified other sites which
can/should use devm_register_reboot_notifier()? I guess quite a lot,
so it's a matter of alerting developers to the new interface. I
wonder how. A checkpatch rule would do it, but that's new ground for
checkpatch.