Re: [PATCH] perf tools: Fix crash on buildid-list with namespace
From: Namhyung Kim
Date: Tue Oct 17 2017 - 20:09:47 EST
On Tue, Oct 17, 2017 at 11:05:55AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 17, 2017 at 10:29:00PM +0900, Namhyung Kim escreveu:
> > Thomas reported that perf buildid-list gets a segfault due to NULL
> > pointer when he ran it on a data with namespace events. It was because
> > the buildid_id__mark_dso_hit_ops lacks the namespace event handler and
> > perf_too__fill_default() didn't set it.
>
> In these cases, next time I suggest you add a Fixes: tag, so that the
> stable@xxxxxxxxxx guys can automatically figure out which kernels need
> this fix, in this case:
>
> Fixes: f3b3614a284d ("perf tools: Add PERF_RECORD_NAMESPACES to include namespaces related info")
Ah right, will add next time.
>
> The script I have for this even adds this CC line:
>
> Cc: Hari Bathini <hbathini@xxxxxxxxxxxxxxxxxx>
>
> I'm adding it,
Thanks,
Namhyung