Re: [PATCH v2] staging: ccree: fix boolreturn.cocci warning
From: Tobin C. Harding
Date: Tue Oct 17 2017 - 22:36:17 EST
On Wed, Oct 18, 2017 at 07:42:53AM +0530, sunil.m@xxxxxxxxxxxx wrote:
> From: Suniel Mahesh <sunil.m@xxxxxxxxxxxx>
>
> Return "false" instead of 0.
>
> This fixes the following coccinelle warning:
> WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
So close! The order of problem description and fix is inverted. What about
```
coccinelle emits: WARNING: return of 0/1 in function 'ssi_is_hw_key' with
return type bool.
Return "false" instead of 0.
```
Good luck,
Tobin.