Re: [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40

[icenowy]

å 2017-10-16 20:06ïMaxime Ripard åéï
> On Mon, Oct 16, 2017 at 05:39:58PM +0800, icenowy@xxxxxxx wrote:
> > å 2017-10-16 17:32ïMaxime Ripard åéï
> > > On Tue, Oct 10, 2017 at 07:24:28AM +0800, Icenowy Zheng wrote:
> > > > >> +			interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> > > > >> +			clocks = <&ccu CLK_BUS_OHCI1>,
> > > > >> +				 <&ccu CLK_BUS_EHCI1>,
> > > > >> +				 <&ccu CLK_USB_OHCI1>;
> > > > >> +			resets = <&ccu RST_BUS_OHCI1>,
> > > > >> +				 <&ccu RST_BUS_EHCI1>;
> > > > >
> > > > >Why do you need to take the OHCI resources too?
> > > >
> > > > AW's strange design -- without OHCI resources taken EHCI
> > > > won't work.
> > >
> > > How has this been tested?
> >
> > As EHCI is probed before OHCI, this behavior is easy to
> > appear if the OHCI resources are removed.
>
> And what is "this behaviour" exactly?
>
> What have you tested, what device did you connect, what is the outcome
> that isn't something you expected, etc.

Oh sorry this weird behavior doesn't exist on R40, although it do exist
on H3/H5/A64.

I will fix this in the next version.

> Maxime