Re: [Outreachy kernel] Re: [PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

[Julia Lawall]

On Wed, 18 Oct 2017, Srishti Sharma wrote:

>
>
> On Wed, Oct 18, 2017 at 8:29 PM, Julia Lawall <julia.lawall@xxxxxxx> wrote:
>
>
>       On Wed, 18 Oct 2017, Srishti Sharma wrote:
>
>       >
>       >
>       > On Wed, Oct 18, 2017 at 6:01 PM, Greg KH
>       <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>       >       On Thu, Oct 05, 2017 at 03:16:42PM +0530, Srishti Sharma
>       wrote:
>       >       > This is a cleanup patch and doesn't change runtime
>       behavior.
>       >       It
>       >       > changes an open coded list traversal to use
>       >       list_for_each_entry_safe.
>       >       > Done using the following semantic patch by coccinelle.
>       >
>       >       You have sent me two different patches, with this same
>       subject.
>       >
>       >       And you have sent me lots of different patches for this
>       same
>       >       driver, I
>       >       don't have any idea which order to apply them in. 
>       Please resend
>       >       them
>       >       all, in an ordered patch series, properly numbered, so I
>       know
>       >       what to do
>       >       here.
>       >
>       >
>       > I had sent them individually because in a patch series they
>       would have the
>       > same subject, as all of them are making similar changes in
>       different files
>       > of the driver. One patch for all files would probably be too
>       long, What do
>       > you suggest I do in this situation ?
>
>       I don't have the specific change handy, but maybe you can
>       incorporate
>       more information about the affected file or about the change
>       itself in teh
>       subject line.  All subject lines need to be unique.
>
>
> I think if I add the file name for every file in the subject, even after
> saying use list_for_each_entry_safe for all of them, that should make them
> unique , right ? As this is what we did last time to make it unique, but I
> should have then sent them as  a patch set.

A patch set is essential when there are multiple changes to the same file,
because one change ight affect how the others apply.

All commits should have unique subject lines, patch series or not.

julia

>
> Regards,
> Srishti
>
>  
>        
>
>       julia
>
>
>       >
>       > Regards, 
>       > Srishti 
>       >
>       >       thanks,
>       >
>       >       greg k-h
>       >
>       >
> > --
> > You received this message because you are subscribed to the Google
> Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an
> > email to outreachy-kernel+unsubscribe@xxxxxxxxxxxxxxxxx
> > To post to this group, send email to
> outreachy-kernel@xxxxxxxxxxxxxxxxx
> > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CAB3L5ozhby6izgNjoB
> ZS6Bw
> > zOgpVcoH1fErt8PN3JhptFv0FGA%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >
>
>
>
>