Re: [PATCH 0/1] net: ethtool: add SmartNIC reset support

[Scott Branden]

+netdev@xxxxxxxxxxxxxxx


On 17-10-18 02:30 PM, Andy Gospodarek wrote:
> On Wed, Oct 18, 2017 at 12:31:28PM -0700, Scott Branden wrote:
> > Hi Andrew,
> >
> >
> > On 17-10-18 12:16 PM, Andrew Lunn wrote:
> > > > Yes, there is also a management processor.
> > > O.K.
> > >
> > > Maybe it would be nice to add some more text to the commit message to
> > > make this clear. Define what an application processor is, and how it
> > > differs from a management processor. But othersize:
> > OK -will add more description to differentiate management processor vs.
> > application processor(s).
> > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> > >
> > > I assume you have another kernel patch to actually make use of this?
> > > It is normal to post the user of a new API in the same series as the
> > > API.
> > I actually wanted to get agreement that the bit define could be added to
> > ethtool before implementing it in driver.
> > If this direction approved we'll implement in driver and submit with this
> > patch series.
> I just noticed that you did not also post this to netdev@xxxxxxxxxxxxxxxx  I
> suspect you are more likely to get review and acceptance if that list is cc'd.
>
> I'm not positive that Linus will take networking patches off this list.
>
> > >       Andrew
> > Thanks,
> >   Scott