Re: [PATCH] thermal/drivers/hisi: disable multi alarm support for hi3660 SoC

[Wangtao (Kevin, Kirin)]

å 2017/10/18 23:54, Daniel Lezcano åé:
> On 18/10/2017 11:15, Tao Wang wrote:
> > From: Kevin Wangtao <kevin.wangtao@xxxxxxxxxx>
> >
> > multi alarm interrupt forced a re-trigger of power_allocator_throttle
> > which changes the PID's actual sampling rate, this isn't optimal for
> > IPA, it is best to disable multi alarm support now and sort out this
> > issue later.
> >
> > Signed-off-by: Kevin Wangtao <kevin.wangtao@xxxxxxxxxx>
>
> Did you test the series with this change?
Yes
> > ---
> >   drivers/thermal/hisi_thermal.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c
> > index 133238a..3b74c12 100644
> > --- a/drivers/thermal/hisi_thermal.c
> > +++ b/drivers/thermal/hisi_thermal.c
> > @@ -360,7 +360,6 @@ static int hi3660_thermal_enable_sensor(struct hisi_thermal_data *data)
> >   
> >   	/* set interrupt threshold */
> >   	value = hi3660_thermal_temp_to_step(sensor->thres_temp[0]);
> > -	value |= hi3660_thermal_temp_to_step(sensor->thres_temp[1]) << 10;
> >   	hi3660_thermal_alarm_set(data->regs, sensor->id, value);
> >   
> >   	/* enable interrupt */