Re: [PATCH] printk: simplify no_printk()

[Masahiro Yamada]

Hi Petr,

2017-10-02 23:56 GMT+09:00 Petr Mladek <pmladek@xxxxxxxx>:
> On Mon 2017-09-18 00:01:44, Masahiro Yamada wrote:
>> Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
>> a value") surrounded the macro implementation with ({ ... }).
>>
>> Now, the inner do { ... } while (0); is redundant.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>
> Looks fine to me. The return value is slightly more visible now ;-)
>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>
>
> JFYI, I have pushed it into for-4.15 branch.
>
> Best Regards,
> Petr


A minor problem.

I think "Reviewed-by: " is missing before Sergey.

I am not sure if this is too late, or not...




commit 38a8c55325f5d4f261fde8b1bebfa2e9daf7c3e1
Author: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
Date:   Mon Sep 18 00:01:44 2017 +0900

    printk: simplify no_printk()

    Commit 069f0cd00df0 ("printk: Make the printk*once() variants return
    a value") surrounded the macro implementation with ({ ... }).

    Now, the inner do { ... } while (0); is redundant.

    Link: http://lkml.kernel.org/r/1505660504-11059-1-git-send-email-yamada.masahiro@xxxxxxxxxxxxx
    Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    Cc: Ingo Molnar <mingo@xxxxxxxxxx>
    Cc: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
    Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>
    Cc: linux-kernel@xxxxxxxxxxxxxxx
    Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
    Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
    Signed-off-by: Petr Mladek <pmladek@xxxxxxxx>



-- 
Best Regards
Masahiro Yamada