Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage()

From: Joe Perches
Date: Thu Oct 19 2017 - 07:29:35 EST


On Thu, 2017-10-19 at 13:18 +0200, SF Markus Elfring wrote:
> > > Omit an extra message for a memory allocation failure in this function.
> > >
> > > This issue was detected by using the Coccinelle software.
> > >
> > > Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> >
> > Applied to modules-next, thanks.
>
> Thanks for your acceptance of this update suggestion after a bit of clarification.
>
> Do you see any need that I should extend subsequent commit messages
> for this software transformation pattern?

Add a description of _why_ this is being done.

Something like:

"because there is a dump_stack() done on allocation failures
without __GFP_JNOWARN"