Re: [PATCH v7 3/4] usb: dwc3: of-simple: Add support to get resets for the device
From: Philipp Zabel
Date: Thu Oct 19 2017 - 07:47:32 EST
On Thu, 2017-10-19 at 14:31 +0300, Felipe Balbi wrote:
> Hi,
>
> Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> writes:
> > Hi Felipe,
> >
> > On Thu, 2017-10-19 at 12:38 +0300, Felipe Balbi wrote:
> > > Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> writes:
> > >
> > > > From: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
> > > >
> > > > Add support to get a list of resets available for the device.
> > > > These resets must be kept de-asserted until the device is
> > > > in use.
> > > >
> > > > Cc: Felipe Balbi <balbi@xxxxxxxxxx>
> > > > Signed-off-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx>
> > > > [p.zabel@xxxxxxxxxxxxxx: switch to hidden reset control array]
> > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > >
> > > now this seems like it depends on patch 1/4, right? Is the reset API
> > > change going on v4.15?
> >
> > Thank you for the reminder. Patch 1 has made it into v4.14-rc1, commit
> > 17c82e206d2a ("reset: Add APIs to manage array of resets"). The other
> > patches could be picked up for v4.15 without any dependency issues.
>
> patch 2 applied fine. patch 3 fails to apply hunk 2.
>
> checking file drivers/usb/dwc3/dwc3-of-simple.c
> Hunk #1 succeeded at 28 (offset -1 lines).
> Hunk #2 FAILED at 98.
> 1 out of 5 hunks FAILED
>
>
> Care to rebase on my testing/next?
Thanks, I'll resend patch 3 separately.
regards
Philipp