Re: [PATCH] net/ethernet/sgi: Code cleanup

[David Miller]

From: Joshua Kinard <kumba@xxxxxxxxxx>
Date: Tue, 17 Oct 2017 13:54:30 -0400

> From: Joshua Kinard <kumba@xxxxxxxxxx>
> 
> The below patch attempts to clean up the code for the in-tree driver
> for IOC3 ethernet and serial console support, primarily used by SGI
> MIPS platforms.  Notable changes include:
> 
>   - Lots of whitespace cleanup
>   - Using shorthand integer types (u16, u32, etc) where appropriate

These seem to be arbitrary, "unsigned int" is a fine value for a
hash computation.

You're also making many different kinds of changes in one patch
which makes it very difficult to review.

This driver is also for such ancient hardware, that the risk
of potentially breaking the driver far outweighs the value of
"cleaning up" the code.