Re: [PATCH] PCI: dwc: dra7xx: Print link state to console for debug

[Faiz Abbas]

Hi,

On Tuesday 17 October 2017 08:15 PM, David Laight wrote:
> From: Joe Perches
>> Sent: 17 October 2017 07:35
>> On Tue, 2017-10-17 at 11:13 +0530, Faiz Abbas wrote:
>>> Enable support for printing the LTSSM link state for debugging PCI
>>> when link is down.
>> []
>>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>>> index 34427a6..7b150b0 100644
>>> --- a/drivers/pci/dwc/pci-dra7xx.c
>>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>>> @@ -98,6 +98,18 @@ struct dra7xx_pcie_of_data {
>>>
>>>  #define to_dra7xx_pcie(x)	dev_get_drvdata((x)->dev)
>>>
>>> +static char state[][20] = {
>>> +	"DETECT_QUIET", "DETECT_ACT", "POLL_ACTIVE", "POLL_COMPLIANCE",
>>> +	"POLL_CONFIG", "PRE_DETECT_QUIET", "DETECT_WAIT", "CFG_LINKWD_START",
>>> +	"CFG_LINKWD_ACEPT", "CFG_LANENUM_WAIT", "CFG_LANENUM_ACEPT",
>>> +	"CFG_COMPLETE", "CFG_IDLE", "RCVRY_LOCK", "RCVRY_SPEED",
>>> +	"RCVRY_RCVRCFG", "RCVRY_IDLE", "L0", "L0S", "L123_SEND_EIDLE",
>>> +	"L1_IDLE", "L2_IDLE", "L2_WAKE", "DISABLED_ENTRY", "DISABLED_IDLE",
>>> +	"DISABLED", "LPBK_ENTRY", "LPBK_ACTIVE", "LPBK_EXIT",
>>> +	"LPBK_EXIT_TIMEOUT", "HOT_RESET_ENTRY", "HOT_RESET", "RCVRY_EQ0",
>>> +	"RCVRY_EQ1", "RCVRY_EQ2", "RCVRY_EQ3"
>>
>> what's wrong with using the far more typical
>>
>> static const char *link_state[] = {
>> 	"DETECT_QUIET",
>> 	...
> 
> Or 4 aligned columns.

4 aligned columns are difficult as the strings are of different sizes.

> Better still used named initialisers:
> 	[xxx_DETECT_QUIET] = "DETECT_QUIET",
> you really don't want an 'off-by-one' in that list.

Sounds good. Let me see how I can implement this.

Thanks,
Faiz